[PATCH] D69462: [DebugInfo]: Support for debug_loclists.dwo section in llvm and llvm-dwarfdump.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2462
+  MCSymbol *TableEnd = nullptr;
+  if (IsLocLists) {
     Asm->OutStreamer->SwitchSection(
----------------
This function looks like it may be more readable if it were organized like this:

```
if (getDwarfVersion() >= 5) {
  for (const auto &List : DebugLocs.getLists())
    ...
} else /* DWARF v2-4 */ {
  for (const auto &List : DebugLocs.getLists())
    ...
}
```


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:2500
+      // .debug_loclists section ends with DW_LLE_end_of_list.
+      // Both loclists v5 and
+      Asm->OutStreamer->AddComment("DW_LLE_end_of_list");
----------------
Can you please make sure all comments are complete sentences ending in a `.`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69462/new/

https://reviews.llvm.org/D69462