[PATCH] D69264: [AIX] Lowering CPI/JTI/BA to MIR

[Sean Fertile via Phabricator via llvm-commits]

sfertile accepted this revision.
sfertile added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: wuzish.

LGTM.



================
Comment at: llvm/test/CodeGen/PowerPC/lower_constant_pool_index_aix.ll:4
+; RUN: --check-prefix=32SMALL-MIR %s
+  
+; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff \
----------------
Minor nit: There is an extra space at the start of this blank line.


================
Comment at: llvm/test/CodeGen/PowerPC/lower_jump_table_aix.ll:4
+; RUN: --check-prefix=32SMALL-MIR %s
+  
+; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff \
----------------
Minor nit: Extra space here too.


================
Comment at: llvm/test/CodeGen/PowerPC/lower_jump_table_aix.ll:54
+; 32LARGE-MIR: renamable $r[[REG4:[0-9]+]] = RLWINM killed renamable $r[[REG3:[0-9]+]], 2, 0, 29
+; 32LARGE-MIR: renamable $r[[REG5:[0-9]+]] = LWZX killed renamable $r[[REG4]], killed renamable $r[[REG2]] :: (load 4 from jump-table) 
+
----------------
Minor nit: I believe there is some trailing white space at the end of this line.


================
Comment at: llvm/test/CodeGen/PowerPC/lower_jump_table_aix.ll:64
+; 64LARGE-MIR: renamable $x[[REG5:[0-9]+]] = LWAX killed renamable $x[[REG4]], killed renamable $x[[REG2]] :: (load 4 from jump-table)
+
----------------
Minor nit: extra blank line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69264/new/

https://reviews.llvm.org/D69264