[PATCH] D69234: [bugpoint] Reduce metadata that does not contribute to crash.

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 11:19:33 PDT 2019


reames requested changes to this revision.
reames added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/tools/bugpoint-passes/TestPasses.cpp:175
+    C("bugpoint-crashmetadata", "BugPoint Test Pass - Intentionally crash on "
+                                "instructions with tbaa metadata");
----------------
*range* metadata


================
Comment at: llvm/tools/bugpoint/CrashDebugger.cpp:864
+  for (Function &F : *M)
+    for (Instruction &Inst : instructions(F)) {
+      Inst.dropUnknownNonDebugMetadata();
----------------
Er, it really looks like you should be iterating the instruction set above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69234/new/

https://reviews.llvm.org/D69234





More information about the llvm-commits mailing list