[PATCH] D68789: [LoopNest]: Analysis to discover properties of a loop nest.

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

I am very much not convinced of either this analysis or the motivation.

First, restricting transformations to perfectly nested loops when there are known techniques to handle imperfect loop nests does not seem worthwhile.  As such, I strongly reject the notion that we should make perfect nesting a requirement for all of our loop transformations.

Secondly, even if I accept the premise that perfect nesting is useful, I do not see the value of this analysis pass.  We have an existing description of a loop and loop nest in loop info.  How is this anything more than a set of helper function implemented over the existing analysis?  (i.e. LoopNestUtils.hpp/cpp?)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68789/new/

https://reviews.llvm.org/D68789