[PATCH] D69103: Backend for NEC SX-Aurora

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

In D69103#1722659 <https://reviews.llvm.org/D69103#1722659>, @rengolin wrote:

> This plan has all the requirements for adding a new target (http://llvm.org/docs/DeveloperPolicy.html#new-targets), mainly: ISA document, current implementation, code owner, buildbots. You just need to make sure it's marked as *experimental*, as stated in the policy.


Great! How do we mark the target to make it clear it's experimental?

> The Github repo mentioned (branch develop) is a bit hard to make out what are the changes necessary, as it has only merges from other branches. Given that we'll have to judge what the next series of patches will be, and that you'll have to upstream them in order, it would be good if they were more or less organised in the way they will be upstreamed in the source. This will also help you rebase changes that are requested in the reviews, which weren't originally in your repo, and test them before continuing the upstreaming process.

That's a good point. We probably won't stick to the existing commits but repackage the github code into a linear sequence of testable patches for review. We will go for instruction encodings, register decl and scalar codegen first, then extend to vector intrinsics and finally to LLVM-VP.

How much of that do you need to see before this patch here can be approved? I am asking because as we are refactoring the out-of-tree patches for upstreaming, it'd ease the pain of rebasing if some of the changes outside of `lib/Target/VE` could already go in. Beyond this patch, the critical changes are:

- TableGen:
  - IntrinsicEmitter (Additional `IIT_Info` enum entries).
  - CodeGenTarget (`MVT` enum entries).
- Clang: VE toolchain.

Later, we will add target-specific vector intrinsics to Clang and LLVM.

> Other than that, it would be nice if other code owners could review and approve.

Thanks! :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69103/new/

https://reviews.llvm.org/D69103