[PATCH] D69480: [TargetLowering] Move the setBooleanContents check on (xor (setcc), (setcc)) == / != 1 -> (setcc) != / == (setcc) to the right place

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 10:28:48 PDT 2019


craig.topper added a comment.

In D69480#1723050 <https://reviews.llvm.org/D69480#1723050>, @RKSimon wrote:

> Test case?


I don't have one. Would need a target that has different boolean contents for scalar fp and scalar int. I think maybe one of the subtargets have mips has the mix? And then you would need to mix an fp compare and int compare. And you'd have to delay the combine until after type legalization so that you don't hit the i1 check. Any suggestions how to do that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69480/new/

https://reviews.llvm.org/D69480





More information about the llvm-commits mailing list