[PATCH] D68633: [utils] InlineFunction: fix for debug info affecting optimizations

[Bjorn Pettersson via Phabricator via llvm-commits]

bjope added a comment.

In D68633#1723326 <https://reviews.llvm.org/D68633#1723326>, @yechunliang wrote:

> @bjope thanks for help, to be honest, I don't know the process or execution of commit, I thought I have no commit permission right now.


The procedure should be described here:

  http://llvm.org/docs/Contributing.html#how-to-submit-a-patch

It says

> This cycle continues until all requests and comments have been addressed and a reviewer accepts the patch with a Looks good to me or LGTM. Once that is done the change can be committed. If you do not have commit access, please let people know during the review and someone should commit it on your behalf.

So it is perfectly OK to ask the reviewers to submit it for you.

When your contribution increases, you can obtain commit access (to both push your own patches and also maybe to help new contributers). That should be covered by

  http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

(not sure if the process will change due to the ongoing transfer from SVN->GitHub).

I haven't pushed directly to GitHub myself yet. I'll try to commit this patch for you, also verifying that my commit access still works.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68633/new/

https://reviews.llvm.org/D68633