[PATCH] D69508: [ARM] Add vrev32 NEON fp16 patterns

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 28 07:06:45 PDT 2019


dmgreen added a comment.

Yep! That's what I meant. Neon+fullfp16, this fails to select. This test runs in that configuration now. The RHS check lines are missing because it crashes failing to select.

Without fullfp16 you are right that we would never see a f16 vector, so the patterns would never be used. We would promote the f16's to f32's before that point, I believe.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69508/new/

https://reviews.llvm.org/D69508





More information about the llvm-commits mailing list