[PATCH] D69339: [SelectionDAG] Add support for FP_ROUND in WidenVectorOperand.

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 27 20:36:20 PDT 2019


arsenm added inline comments.


================
Comment at: llvm/test/CodeGen/AMDGPU/fptrunc.ll:34
+; FUNC-LABEL: {{^}}fptrunc_v3f64_to_v3f32:
+; GCN: v_cvt_f32_f64_e32
+; GCN: v_cvt_f32_f64_e32
----------------
foad wrote:
> craig.topper wrote:
> > Is this hitting the unrolling path rather than any of the code that creates a wider node?
> The test definitely fails without the fix above, but I haven't looked in detail at how it is handled.
I would expect this to hit the unroll path. v3f64 isn't legal


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69339/new/

https://reviews.llvm.org/D69339





More information about the llvm-commits mailing list