[PATCH] D69461: [XRay] Sanitize DOT labels in graph output

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 27 15:06:33 PDT 2019


dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.

LGTM with one nit. Thanks!



================
Comment at: llvm/tools/llvm-xray/xray-graph.cpp:175
+// certain characters.
+static std::string escapeString(const std::string &Label) {
+  std::string Str;
----------------
nit: Consider using StringRef instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69461/new/

https://reviews.llvm.org/D69461





More information about the llvm-commits mailing list