[PATCH] D69437: [RAGreedy] Enable -consider-local-interval-cost by default

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

+1 here. It fixes an issue that has already been found on X86 and we've now found a case of on AArch64. It might well come up on other architectures, it's just impossible to tell where. Turning this one for all architectures sounds like the most sensible way forward. If X86 are accepting the compile times changes (which don't seem too big), I believe they will be acceptable elsewhere too.

The fact that no other tests have changed is a good sign. I do think this can cause a bit of performance noise from the register allocation changing. In the testing I ran it was just positives and negatives in different places.

Because this is target independent though, it's probably worth sending a message over to llvm-dev explaining the problem and that we think it's best to turn this on for all backends. Give anyone interested a chance to raise concerns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69437/new/

https://reviews.llvm.org/D69437