[PATCH] D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/MachineVerifier.cpp:2328
+              "%.bb." + Twine((*PrI)->getNumber());
+            report(Msg.str().c_str(), &MBB);
+          }
----------------
I don't think this needs the .c_str()


================
Comment at: lib/Target/SystemZ/SystemZElimCompare.cpp:590
   // instructions before it.
-  bool CompleteCCUsers = !isCCLiveOut(MBB);
+  bool CompleteCCUsers = !MBB.isLiveOut(SystemZ::CC);
   SmallVector<MachineInstr *, 4> CCUsers;
----------------
I would expect this pass to use LivePhysRegs instead of checking the block function directly


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68267/new/

https://reviews.llvm.org/D68267