[PATCH] D68983: [yaml2obj, obj2yaml] - Add support for SHT_NOTE sections.

Sat Oct 26 04:51:06 PDT 2019

grimar marked 2 inline comments as done.
grimar added inline comments.

================
Comment at: llvm/include/llvm/Support/YAMLTraits.h:652-653
     return QuotingType::Single;
-  if (isspace(static_cast<unsigned char>(S.front())) ||
-      isspace(static_cast<unsigned char>(S.back())))
     return QuotingType::Single;
----------------
rupprecht wrote:
> Was this part of the change intentional? This looks like a rebase that accidentally reverted one of your previous patches.
Thanks! It wasn't intentional. I've moved this and other my active patches to monorepo and I guess I've forgot to rebase it. I am going to recommit this part.

(I've re-checked that the existing test case for this, which is invalid-section-name.yaml fails for me now under windows in debug. I guess bots never build in debug probably, that is why it was not catched by them).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68983/new/

https://reviews.llvm.org/D68983