[PATCH] D69429: [ADT] Adds equality operator for SmallPtrSet

[David Tellenbach via Phabricator via llvm-commits]

tellenbach added inline comments.


================
Comment at: llvm/include/llvm/ADT/SmallPtrSet.h:422
+
+  for (auto *KV : LHS)
+    if (!RHS.count(KV))
----------------
NIT: Can this be `const`?


================
Comment at: llvm/unittests/ADT/SmallPtrSetTest.cpp:334
+// Test equality comparison.
+TEST(SmallPtrSetTest, EqualityComparison) {
+  int buf[10];
----------------
Can you add a unit test for testing the inequality of different-sized sets?


================
Comment at: llvm/unittests/ADT/SmallPtrSetTest.cpp:335
+TEST(SmallPtrSetTest, EqualityComparison) {
+  int buf[10];
+
----------------
Can you use a smaller buffer and initialize it?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69429/new/

https://reviews.llvm.org/D69429