[PATCH] D69418: [llvm-ar] Add output option for extract operation

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 18:31:44 PDT 2019


MaskRay added a comment.

This is a nice addition to llvm-ar as I discussed with Yi offline, but I want to hear from others.



================
Comment at: llvm/test/tools/llvm-ar/extract.test:20
 RUN: rm %t/extracted/a.txt
-RUN: cd %t/extracted && llvm-ar x %t/archive.a
+RUN: llvm-ar --output=%t/extracted x %t/archive.a
 RUN: diff %t/a.txt %t/extracted/a.txt 
----------------
There will not be direct `x` operation tests with this change. Adding a new test is probably better. Please also test extracting more than one file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69418/new/

https://reviews.llvm.org/D69418





More information about the llvm-commits mailing list