[PATCH] D69141: [Remarks] Add support for linking remarks

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg marked an inline comment as done.
thegameg added inline comments.


================
Comment at: llvm/include/llvm/Remarks/Remark.h:119
+  if (!LHS && RHS)
+    return true;
+  if (LHS && !RHS)
----------------
JDevlieghere wrote:
> Why does this not return false?
This way, we order `None` before a valid `Optional<T>`. For example, remarks with no debug location will appear first.


================
Comment at: llvm/lib/Remarks/RemarkLinker.cpp:110
+      return Error::success();
+  } else {
+    return SectionOrErr.takeError();
----------------
JDevlieghere wrote:
> No else after return
This one is needed in order to access `SectionOrErr`. I can remove it from the condition if you think it's nicer.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69141/new/

https://reviews.llvm.org/D69141