[PATCH] D69407: build: remove `LLVM_CXX_STD` extension point

Shoaib Meenai via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 14:50:12 PDT 2019


smeenai added a comment.

In D69407#1720499 <https://reviews.llvm.org/D69407#1720499>, @xiaobai wrote:

> Why do you want `LLVM_CXX_STD` to be removed? I suppose somebody will eventually add `LLVM_ENABLE_CXX2A`, which will require additional logic to ensure that somebody doesn't set `LLVM_ENABLE_CXX2A` and `LLVM_ENABLE_CXX1Z` at the same time. I think this can be avoided by removing `LLVM_ENABLE_CXX1Z` entirely and going through `LLVM_CXX_STD` entirely.


Can we avoid having any custom variables for this at all and just use `CMAKE_CXX_STANDARD`? People can do `-DCMAKE_CXX_STANDARD=17` or whatever else they want.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69407/new/

https://reviews.llvm.org/D69407





More information about the llvm-commits mailing list