[PATCH] D69384: Add unlikely attribute to outlined function

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 14:38:34 PDT 2019


xbolva00 added a comment.

In D69384#1720453 <https://reviews.llvm.org/D69384#1720453>, @tejohnson wrote:

> In D69384#1720434 <https://reviews.llvm.org/D69384#1720434>, @hiraditya wrote:
>
> > Because my goal is to improve outlining without PGO (with static analysis), I'm wondering what would be the best place to put this other than HotColdSplitting.
>
>
> Perhaps the code in CodeGenPrepare.cpp should fall back to looking for the Cold attribute if there is no profile (since this attribute can be used independent of splitting).


+1


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69384/new/

https://reviews.llvm.org/D69384





More information about the llvm-commits mailing list