[PATCH] D69313: Handle more crt*.o filename variants.
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Thu Oct 24 11:32:19 PDT 2019
    
    
  
ruiu added inline comments.
================
Comment at: lld/ELF/OutputSections.cpp:395
+static bool isCrtbegin(StringRef s) {
+  s = llvm::sys::path::filename(s);
+  static std::regex re(R"((clang_rt\.)?crtbegin[ST]?(\-.*)?\.o)");
----------------
Remove `llvm::`.
Please swap this line with the following line so that `static` variable definitions are at the beginning of the function.
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69313/new/
https://reviews.llvm.org/D69313
    
    
More information about the llvm-commits
mailing list