[PATCH] D69384: Add unlikely attribute to outlined function

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 10:47:50 PDT 2019


vsk added a comment.

Yes, this does need a test, but I'm also not sure why this belongs in the hot/cold splitting pass.

It's possible to mark functions with the `cold` attribute outside of the splitting pass. Shouldn't all of these cold functions should have a `.unlikely` section prefix? If so, setting the section prefix should be done later (say, in PreISelLowering).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69384/new/

https://reviews.llvm.org/D69384





More information about the llvm-commits mailing list