[PATCH] D69387: [ConstantRange] Add toKnownBits() method

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added inline comments.


================
Comment at: llvm/unittests/IR/ConstantRangeTest.cpp:2144
+      EXPECT_EQ(KBFromReferenceUnsignedCR, KBFromReferenceSignedCR);
+      EXPECT_EQ(KBFromReferenceUnsignedCR, Known);
     }
----------------
nikic wrote:
> Your test is checking that the result of toKnownBits() is correct //under the assumption that it came from ConstantRange::fromKnownBits()//. However, fromKnownBits() can not produce all possible ranges.
Thanks for pointing that out, i indeed haven't fully thought that trough, as i was mostly wondering if this should exist at all.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69387/new/

https://reviews.llvm.org/D69387