[PATCH] D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.

Alexey Lapshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 10:21:34 PDT 2019


avl marked an inline comment as done.
avl added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:80
+    /// X86 compare and logical compare instructions.
+    CMP,
+    COMI,
----------------
asl wrote:
> avl wrote:
> > asl wrote:
> > > Do you really need these changes?
> > no, I don`t . it was done by clang-format.
> Please do not add unrelated changes
Ok, I will delete them. clang-format added above changes since VARARG_THUNK_SAVE_XMM_REGS was added. In that sense the changes are related. But OK, I will delete them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69372/new/

https://reviews.llvm.org/D69372





More information about the llvm-commits mailing list