[PATCH] D69372: [X86][VARARG] Avoid spilling xmm vararg arguments.

Anton Korobeynikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 08:48:16 PDT 2019


asl added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3502
+      } else {
+        // TODO: add check for possibility to not store guarded vararg
+        // TODO: parameters. If function contains only musttail calls, if it
----------------
What is the status of all these TODO here and there?


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.h:80
+    /// X86 compare and logical compare instructions.
+    CMP,
+    COMI,
----------------
Do you really need these changes?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69372/new/

https://reviews.llvm.org/D69372





More information about the llvm-commits mailing list