[PATCH] D67158: [ARM] Begin adding IR intrinsics for MVE instructions.

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 24 07:14:05 PDT 2019


dmgreen accepted this revision.
dmgreen added a subscriber: samparker.
dmgreen added a comment.
This revision is now accepted and ready to land.

Thanks! LGTM, with just one comment that might be better left for Sam.



================
Comment at: llvm/lib/Target/ARM/ARMInstrMVE.td:2841
+  def "" : MVE_VADDSUBFMA_fp<iname, VTI.Suffix, VTI.Size{0}, 0, 1, bit_21> {
+    let validForTailPredication = 1;
+  }
----------------
Can this move into MVE_VADDSUBFMA_fp? I'm pretty sure VFMA should be fine there too.  Feel free to leave that for @samparker though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67158/new/

https://reviews.llvm.org/D67158





More information about the llvm-commits mailing list