[PATCH] D69101: [AIX] Refactor AIX Call Lowering to use CCState. NFCI.

Zarko Todorovski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 23 18:30:22 PDT 2019


ZarkoCA added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-byval-param.ll:1
+; RUN: not llc -mtriple powerpc-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
+; RUN: not llc -mtriple powerpc64-ibm-aix-xcoff < %s 2>&1 | FileCheck %s
----------------
jasonliu wrote:
> add -verify-machine-instr, -mcpu to all the llc command?
For the calling conventions we've been using -stop-after=machine-cp, so no need for -verify-machine-instr etc at this point. 

That said, I guess these testcase are here for to generate the error but it would be useful if the RUN command was reflected what we usually do, that way we make sure the tests are uniform if/when we enable these. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69101/new/

https://reviews.llvm.org/D69101





More information about the llvm-commits mailing list