[PATCH] D67185: [RISCV] Add support for -ffixed-xX flags

[Simon Cook via Phabricator via llvm-commits]

simoncook added a comment.

In D67185#1708177 <https://reviews.llvm.org/D67185#1708177>, @asb wrote:

> In D67185#1707849 <https://reviews.llvm.org/D67185#1707849>, @lenary wrote:
>
> > Note, D68862 <https://reviews.llvm.org/D68862> is in-progress at the moment, which is related to this patch.
>
>
> Indeed - Simon, could you please go through that patch and ensure that the implementation here is aligned to it (or indeed, feed back on that patch if you feel they should be doing something differently). Thanks!


It looks like that patch is following the same route we are, using target features to implement this, both inspired by AArch64. There were some questions about using SubtargetFeatures for these kind of purposes and should these be function attributes instead. Given we’re already using features for things like relaxation, I’m inclined to stick with target features rather than split these between two different methodologies, especially since we have the AArch64 precedence in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67185/new/

https://reviews.llvm.org/D67185