[PATCH] D69321: [LVI][CVP] LazyValueInfoImpl::solveBlockValueBinaryOp(): use no-wrap flags from `add` op

Wed Oct 23 08:05:17 PDT 2019

lebedev.ri marked 2 inline comments as done.
lebedev.ri added a comment.

In D69321#1718474 <https://reviews.llvm.org/D69321#1718474>, @nikic wrote:

> LGTM
>
> Thanks for looking into this!

Thank you for the review.

> I think we should definitely do this change as the functionality already exists, but based on the numbers,
>  it probably doesn't make sense to invest in NoWrap implementations of other operators
>  unless we also need them for something else (SCEV was the original motivation here).

It's indeed hard to say whether handling of other three OBO will be worth it,
without actually implementing everything and measuring..

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69321/new/

https://reviews.llvm.org/D69321