[PATCH] D68841: [PowerPC] Do not convert loop to HW loop if the body contains calls to lrint/lround

[Hal Finkel via Phabricator via llvm-commits]

hfinkel added inline comments.


================
Comment at: lib/Target/PowerPC/PPCTargetTransformInfo.cpp:281
+          // a call for safety.
+          default: return true;
           // If we have a call to ppc_is_decremented_ctr_nonzero, or ppc_mtctr
----------------
nemanjai wrote:
> @hfinkel What do you think about this conservative approach to prevent similar issues in the future? This is I think a third time I address a similar bug.
I really thought that I had replied to this already, but apparently not. I'm okay with that, but I'd like to do it in a separate commit, and we need to audit the existing intrinsics and add them as necessary (both ones that have straightforward codegen and ones like llvm.assume which have no codegen).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68841/new/

https://reviews.llvm.org/D68841