[PATCH] D69103: Backend for NEC SX-Aurora

Tue Oct 22 17:22:50 PDT 2019

simoll marked an inline comment as done.
simoll added a comment.

In D69103#1714433 <https://reviews.llvm.org/D69103#1714433>, @bcain wrote:

> Shouldn't the first patch add to `LLVM_TARGETS_TO_BUILD` or `LLVM_EXPERIMENTAL_TARGETS_TO_BUILD`?

This patch adds VE as an experimental target, which is not build by default. If users want VE support, they add it to `LLVM_EXPERIMENTAL_TARGETS_TO_BUILD` when they configure the build.

================
Comment at: llvm/test/CodeGen/VE/target_support.ll:1
+; RUN: not not llc < %s -asm-verbose=false -march=ve 2>&1 | FileCheck %s --check-prefix=ARCH
+; RUN: not not llc < %s -asm-verbose=false -mtriple=ve 2>&1 | FileCheck %s --check-prefix=TRIPLE
----------------
bcain wrote:
> `not not` can't be right, can it?  Just run `llc` directly.
The 'not not' makes sure the test does not crash when 'llc' crashes (which is anticipated in a successful run). We need this because if the tests succeeds, the 'llc' call crashes trying to create initialize VE codegen. The test fails when 'llc' reports that 've' is not a valid target.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69103/new/

https://reviews.llvm.org/D69103