[PATCH] D68267: [MBB LiveIn lists, MachineVerifier, SystemZ] New method isLiveOut() and mverifier improvement.

Bjorn Pettersson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 12:49:09 PDT 2019


bjope added inline comments.


================
Comment at: lib/CodeGen/MachineBasicBlock.cpp:472
 
+bool MachineBasicBlock::isLiveOut(MCRegister PhysReg) const {
+  assert(PhysReg.isPhysical() && "Expected physreg");
----------------
Afaict this does not work for callee saved registers (nor pristine regs (not used in the entire function), nor when being live out from the exit block). Nor does it work for reserved registers (aren't they always considered live out from the exit block?).



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68267/new/

https://reviews.llvm.org/D68267





More information about the llvm-commits mailing list