[PATCH] D69294: [LLD][ELF] Support -[no-]mmap-output-file

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 11:46:31 PDT 2019


ruiu added a comment.

I should have reviewed this one first, sorry. I'm a little sad that BtrFS behaves poorly under a certain condition, and I feel like the filesystem is at fault than the linker, but I'm fine with actually supporting -no-mmap-output-file option as a workaround. That's practical and easy to implement.



================
Comment at: lld/ELF/Config.h:199
   bool writeAddends;
+  bool mmapOutputFile;
   bool zCombreloc;
----------------
Sort asciibetically.


================
Comment at: lld/ELF/Options.td:410
+defm mmap_output_file: B<"mmap-output-file",
+    "Map the output file for writing (default)",
+    "Do not map the output file for writing">;
----------------
Map -> Mmap


================
Comment at: lld/ELF/Options.td:411
+    "Map the output file for writing (default)",
+    "Do not map the output file for writing">;
+
----------------
map -> mmap


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69294/new/

https://reviews.llvm.org/D69294





More information about the llvm-commits mailing list