[llvm] e5dd30f - [ThinLTO] Add code comment. NFC

Eugene Leviant via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 22 05:56:05 PDT 2019


Author: Eugene Leviant
Date: 2019-10-22T12:57:23Z
New Revision: e5dd30f77e10b3fa3395312045c06e5e15f9620e

URL: https://github.com/llvm/llvm-project/commit/e5dd30f77e10b3fa3395312045c06e5e15f9620e
DIFF: https://github.com/llvm/llvm-project/commit/e5dd30f77e10b3fa3395312045c06e5e15f9620e.diff

LOG: [ThinLTO] Add code comment. NFC

llvm-svn: 375500

Added: 
    

Modified: 
    llvm/lib/Transforms/IPO/FunctionImport.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp
index 2ce8c92ec8ab..3f5cc078d75f 100644
--- a/llvm/lib/Transforms/IPO/FunctionImport.cpp
+++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp
@@ -952,6 +952,9 @@ void llvm::thinLTOResolvePrevailingInModule(
     if (NewLinkage == GV.getLinkage())
       return;
     if (GlobalValue::isLocalLinkage(GV.getLinkage()) ||
+        // Don't internalize anything here, because the code below
+        // lacks necessary correctness checks. Leave this job to
+        // LLVM 'internalize' pass.
         GlobalValue::isLocalLinkage(NewLinkage) ||
         // In case it was dead and already converted to declaration.
         GV.isDeclaration())


        


More information about the llvm-commits mailing list