[PATCH] D68195: [DAGCombiner] Peek through vector concats when trying to combine shuffles.

[Dávid Bolvanský via Phabricator via llvm-commits]

xbolva00 added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:16510
+        int Step = ArgVal.getOperand(0).getValueType().getVectorNumElements();
+        for (SDValue O : reverse(ArgVal->ops())) {
+          ArgOffset -= Step;
----------------
SDValue Op : 

?


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:16512
+          ArgOffset -= Step;
+          ArgWorkList.emplace_back(ArgOffset, O);
+        }
----------------
O is similar to 0.

So ‘Op’?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68195/new/

https://reviews.llvm.org/D68195