[PATCH] D69239: [CMake] Allow overriding MSVC_DIA_SDK_DIR via CMake

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.

LGTM



================
Comment at: llvm/cmake/config-ix.cmake:477
   # See if the DIA SDK is available and usable.
-  set(MSVC_DIA_SDK_DIR "$ENV{VSINSTALLDIR}DIA SDK")
+  set(MSVC_DIA_SDK_DIR "$ENV{VSINSTALLDIR}DIA SDK" CACHE STRING
+      "Path to the DIA SDK")
----------------
Nit: use PATH instead of STRING.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69239/new/

https://reviews.llvm.org/D69239