[PATCH] D69112: [NFC][XCOFF][AIX] Serialize object file writing for each CsectGroup

[Jason Liu via Phabricator via llvm-commits]

jasonliu marked 2 inline comments as done.
jasonliu added inline comments.


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:120
+  // initialized.
+  static constexpr int16_t UninitializedIndex = -3;
+
----------------
DiggerLin wrote:
> daltenty wrote:
> > Should we specify this relative to XCOFF::N_DEBUG?
> in the symbol table , the section index maybe has -2 ,-1 ,and 0. but for section, it always start from 1, I think keep original  -1 as uninitiated is OK too.
It might be Okay depending on how we write our code later. But there is a chance we could run into risks of needing differentiate a special section number with a truely uninitialized section. So I would prefer to pick a section number that's not used to represent other things. 


================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:573
         SymbolTableIndex += 2;
+        Csect.Size = Layout.getSectionAddressSize(MCSec);
+        if (!SupportLabelDef)
----------------
DiggerLin wrote:
> two Csect.Size = Layout.getSectionAddressSize(MCSec); (duplicate with line 568 ) ?
Thanks. I will address.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69112/new/

https://reviews.llvm.org/D69112