[PATCH] D69259: [NFC][PowerPC] Clean up PPCAsmPrinter with `IsPPC64` and `IsDarwin`

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:947
     const MCExpr *Exp = MCSymbolRefExpr::create(
-        MOSymbol,
-        Subtarget->isPPC64() ? MCSymbolRefExpr::VK_PPC_GOT_TPREL_LO
-                             : MCSymbolRefExpr::VK_PPC_GOT_TPREL,
+        MOSymbol, IsPPC64() ? MCSymbolRefExpr::VK_PPC_GOT_TPREL_LO
+                            : MCSymbolRefExpr::VK_PPC_GOT_TPREL,
----------------
`IsPPC64` is used as a logical value just a few lines up, but is used as a function here.


================
Comment at: llvm/lib/Target/PowerPC/PPCAsmPrinter.cpp:1047
     // Into:      %xd = ADDIS8 %x2, sym at got@tlsld at ha
-    assert(Subtarget->isPPC64() && "Not supported for 32-bit PowerPC");
+    assert(IsPPC64() && "Not supported for 32-bit PowerPC");
     const MachineOperand &MO = MI->getOperand(2);
----------------
Same comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69259/new/

https://reviews.llvm.org/D69259