[PATCH] D52431: [PowerPC] Turn on CR-Logical reducer pass

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 19 13:04:30 PDT 2019


RKSimon added a comment.

In D52431#1715683 <https://reviews.llvm.org/D52431#1715683>, @nemanjai wrote:

> A few updates to the CR Logical Reducer in addition to the pulled patch that turns it on:
>
> - Do not use `std::vector` as there is no real reason for it
> - Do not take references into a growable data structure :(
>
>   @RKSimon Simon, could you do me a big favour and try this out on the machine on which you saw the failures. I am not sure if this is the (only) issue but references into a growable data structure certainly should be removed. Thanks for spotting this issue - I don't know what I was thinking when I originally wrote this a long time ago.


I'll test it out but I'll be travelling to the devmtg so its not going to be until Monday at the earliest.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52431/new/

https://reviews.llvm.org/D52431





More information about the llvm-commits mailing list