[PATCH] D69024: [SystemZ] Add GHC calling convention

Stefan Schulze Frielinghaus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 19 05:31:56 PDT 2019


stefansf marked 4 inline comments as done.
stefansf added a comment.

1. One of the test cases was miss leading in the sense that it simulated a return value which does not exist in GHC calling convention, i.e., every GHC function call is a non-returning tail call. I changed `ghc-cc-01.ll` and removed the miss leading test case.

2. Beside that I changed every `assert(e)` into an `if(e) report_fatal_error(e')`

3. I removed function `CCAssignFnForCall` and introduced `CCIfCC` in `CC_SystemZ`. This should preserve the current semantics and only add the GHC calling convention.

Thank you very much for your detailed review so far!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69024/new/

https://reviews.llvm.org/D69024





More information about the llvm-commits mailing list