[PATCH] D69192: llvm-objdump can error out with an unexpected EOF error if .bss is larger than the file being dumped.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

`inline Expected<StringRef> SectionRef::getContents() const {` is called 4 times in llvm-objdump.cpp. They probably should all be replaced. The method should special case SHT_NOBITS - the sh_offset field of a SHT_NOBITS section is ignored.

Please don't check in a prebuilt binary. I think we can construct a test with yaml2obj.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69192/new/

https://reviews.llvm.org/D69192