[PATCH] D68893: AMDGPU: Split flat offsets that don't fit in DAG

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 18:33:36 PDT 2019


arsenm added a comment.

In D68893#1715404 <https://reviews.llvm.org/D68893#1715404>, @rampitec wrote:

> I.e. ideally we want:
>
> load p
>  load p+128
>  load p+256
>  ...
>  load p+2048-128
>  p1 = p + 2048
>  load p1
>  load p1 + 128
>  load p1 + 256
>  ...
>
> etc for a 128 byte stride.


This would be better, but picking the base constant to use is more difficult. I think this is a next step beyond this patch. I'm not sure splitting this in the IR will work out, as the DAG will try to fold the adds of constants pack together


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68893/new/

https://reviews.llvm.org/D68893





More information about the llvm-commits mailing list