[PATCH] D67643: [lit] Extend internal diff to support `-` argument

[Joel E. Denny via Phabricator via llvm-commits]

jdenny updated this revision to Diff 225717.
jdenny added a comment.

Rebased onto updated D66574 <https://reviews.llvm.org/D66574>.

When `echo` appears in a pipeline, lit calls an external `echo`, which terminates lines with `\r\n` on Windows.  Otherwise, lit uses its internal `echo`, which terminates lines with `\n`, just as does lit's out-of-process builtin `cat`.  Because lit's internal `diff` is sensitive to this difference, after `echo foo > %t.foo`, do `cat %t.foo | diff - %t.foo` not `echo foo | diff - %t.foo` in lit's test suite in this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D67643/new/

https://reviews.llvm.org/D67643

Files:
  llvm/utils/lit/lit/builtin_commands/diff.py
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
  llvm/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
  llvm/utils/lit/tests/max-failures.py
  llvm/utils/lit/tests/shtest-shell.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D67643.225717.patch
Type: text/x-patch
Size: 7872 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191018/ed5f87a5/attachment.bin>