[PATCH] D69137: [profile] Do not cache __llvm_profile_get_filename result

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 16:32:45 PDT 2019


vsk added a comment.

FTR, I'm a bit conflicted about the latest version of this patch. On one hand, hiding `lprofCurFilename` decouples all of the copies of the profiling runtime in a process. On the other, it may cause a regression for users who use the set-filename API with instrumented DSOs. A quick search shows that we have no internal adopters who rely on the behavior, so I'm inclined to go ahead with this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69137/new/

https://reviews.llvm.org/D69137





More information about the llvm-commits mailing list