[PATCH] D69146: [install-name-tool] Add first bits for install-name-tool

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 18 08:38:36 PDT 2019


rupprecht added inline comments.


================
Comment at: llvm/tools/llvm-objcopy/CopyConfig.cpp:728
+  if (InputArgs.size() == 0) {
+    printHelp(T, errs(), "llvm-install-name-tool");
+    exit(1);
----------------
compnerd wrote:
> Do we want to keep with the tradition of naming identically to the tool being replaced?  This should probably be `llvm-install_name_tool` if so.
Most tools do that, but GNU `c++filt` is emulated by `llvm-cxxfilt` and not `llvm-c++filt`, so there's precedence. Personally I think `llvm-install-name-tool` looks better.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69146/new/

https://reviews.llvm.org/D69146





More information about the llvm-commits mailing list