[PATCH] D68064: [Builtins] Provide a mechanism to selectively disable tests based on whether an implementation is provided by a builtin library.

[Dan Liew via Phabricator via llvm-commits]

delcypher added a comment.

Hmm this code looks a little dubious. It's modifying a list while iterating over it and I'm not sure that regex is right.

  # Filter out generic versions of routines that are re-implemented in
        # architecture specific manner.  This prevents multiple definitions of the
        # same symbols, making the symbol selection non-deterministic.
        foreach (_file ${${arch}_SOURCES})
          if (${_file} MATCHES ${_arch}/*)
            get_filename_component(_name ${_file} NAME)
            string(REPLACE ".S" ".c" _cname "${_name}")
            list(REMOVE_ITEM ${arch}_SOURCES ${_cname})
          endif ()
        endforeach ()


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68064/new/

https://reviews.llvm.org/D68064