[PATCH] D69028: [DebugInfo] Correctly place DW_OP_derefs for arguments passed on stack

[Jeremy Morse via Phabricator via llvm-commits]

jmorse marked an inline comment as done.
jmorse added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:5564
+    } else {
+      Expr = DIExpression::prepend(Expr, DIExpression::DerefBefore);
+    }
----------------
vsk wrote:
> Out of curiosity, why can't the sized deref be used for stack values?
Alas, I've no idea -- this is just closely matching the existing code in PrologEpilog. Most likely answer IMO is that it would be legal, but there'd be large amounts of test changes for very little gain.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69028/new/

https://reviews.llvm.org/D69028