[PATCH] D68975: [LLD] [COFF] Try to report source locations for duplicate symbols

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In D68975#1713985 <https://reviews.llvm.org/D68975#1713985>, @ruiu wrote:

> LGTM
>
> I agree that we probably should move this code to lld/Common. I'm not too worried about adding code for mingw to the COFF directory, as long as they are separated clearly. One thing I would do is to add "MinGW only" comment for each function that is used only for mingw. Martin, if you are OK, add the comment to the new functions added in this patch before committing?


Well, some of the new functions are used for codeview as well. And for the verbose dwarf code, originally I had made it MinGW-only with an `if (!config->mingw) return;`, but you said there might be non-MinGW usecases with dwarf info (UEFI), so I removed the check, so the dwarf code no longer is MinGW-only. Do you want a "primarily used by MinGW" comment instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68975/new/

https://reviews.llvm.org/D68975