[PATCH] D69152: [gicombiner] Add GIMatchTree and use it for the code generation

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 18:39:45 PDT 2019


dsanders created this revision.
dsanders added reviewers: bogner, volkan.
Herald added a subscriber: mgorny.
Herald added a project: LLVM.

GIMatchTree's job is to build a decision tree by zipping all the
GIMatchDag's together.

Each DAG is added to the tree builder as a leaf and partitioners are used
to subdivide each node until there are no more partitioners to apply. At
this point, the code generator is responsible for testing any untested
predicates and following any unvisited traversals (there shouldn't be any
of the latter as the getVRegDef partitioner handles them all).

Note that the leaves don't always fit into partitions cleanly and the
partitions may overlap as a result. This is resolved by cloning the leaf
into every partition it belongs to. One example of this is a rule that can
match one of N opcodes. The leaf for this rule would end up in N partitions
when processed by the opcode partitioner. A similar example is the
getVRegDef partitioner where having rules (add $a, $b), and (add ($a, $b), $c)
will result in the former being in the partition for successfully
following the vreg-def and failing to do so as it doesn't care which
happens.

Depends on D69151 <https://reviews.llvm.org/D69151>


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D69152

Files:
  llvm/include/llvm/Target/GlobalISel/Combine.td
  llvm/test/TableGen/GICombinerEmitter/match-tree.td
  llvm/utils/TableGen/GICombinerEmitter.cpp
  llvm/utils/TableGen/GlobalISel/CMakeLists.txt
  llvm/utils/TableGen/GlobalISel/GIMatchDag.h
  llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.cpp
  llvm/utils/TableGen/GlobalISel/GIMatchDagEdge.h
  llvm/utils/TableGen/GlobalISel/GIMatchDagInstr.h
  llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.cpp
  llvm/utils/TableGen/GlobalISel/GIMatchDagPredicate.h
  llvm/utils/TableGen/GlobalISel/GIMatchDagPredicateDependencyEdge.cpp
  llvm/utils/TableGen/GlobalISel/GIMatchTree.cpp
  llvm/utils/TableGen/GlobalISel/GIMatchTree.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D69152.225558.patch
Type: text/x-patch
Size: 92801 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191018/c7936e6e/attachment-0001.bin>


More information about the llvm-commits mailing list