[zorg] r375193 - Check out the test-suite first to prevent poisoning got_revision property.

[Galina Kistanova via llvm-commits]

Author: gkistanova
Date: Thu Oct 17 17:42:03 2019
New Revision: 375193

URL: http://llvm.org/viewvc/llvm-project?rev=375193&view=rev
Log:
Check out the test-suite first to prevent poisoning got_revision property.

Modified:
    zorg/trunk/zorg/buildbot/builders/ABITestsuitBuilder.py

Modified: zorg/trunk/zorg/buildbot/builders/ABITestsuitBuilder.py
URL: http://llvm.org/viewvc/llvm-project/zorg/trunk/zorg/buildbot/builders/ABITestsuitBuilder.py?rev=375193&r1=375192&r2=375193&view=diff
==============================================================================
--- zorg/trunk/zorg/buildbot/builders/ABITestsuitBuilder.py (original)
+++ zorg/trunk/zorg/buildbot/builders/ABITestsuitBuilder.py Thu Oct 17 17:42:03 2019
@@ -36,12 +36,13 @@ def getABITestsuitBuildFactory(
         ('-G',                      'Ninja'),
         ])
 
-    f = UnifiedTreeBuilder.getCmakeBuildFactory(
+    cleanBuildRequested = lambda step: step.build.getProperty("clean", default=step.build.getProperty("clean_obj")) or clean
+
+    f = UnifiedTreeBuilder.getLLVMBuildFactoryAndPrepareForSourcecodeSteps(
             depends_on_projects=depends_on_projects,
             llvm_srcdir="llvm",
             obj_dir="build",
-            clean=clean,
-            extra_configure_args=cmake_args,
+            cleanBuildRequested=cleanBuildRequested,
             env=merged_env,
             **kwargs) # Pass through all the extra arguments.
 
@@ -49,6 +50,24 @@ def getABITestsuitBuildFactory(
     # TODO: Remove this once legacy mode gets dropped.
     kwargs.pop('is_legacy_mode', None)
 
+    # First of all, we shall checkout the latest test-suite.
+    f.addGetSourcecodeForProject(
+        project='test-suite',
+        src_dir='test-suite',
+        alwaysUseLatest=True,
+        **kwargs)
+
+    # Then get the LLVM source code revision this particular build is for.
+    f.addGetSourcecodeSteps(**kwargs)
+
+    UnifiedTreeBuilder.addCmakeSteps(
+        f,
+        cleanBuildRequested=cleanBuildRequested,
+        obj_dir=f.obj_dir,
+        extra_configure_args=extra_configure_args,
+        env=env,
+        **kwargs)
+
     f.addStep(NinjaCommand(name="build-unified-tree",
                            haltOnFailure=True,
                            description=["Build", "unified", "tree"],
@@ -57,13 +76,6 @@ def getABITestsuitBuildFactory(
                            **kwargs # Pass through all the extra arguments.
                            ))
 
-    # Checkout the test-suite.
-    f.addGetSourcecodeForProject(
-        project='test-suite',
-        src_dir='test-suite',
-        alwaysUseLatest=True,
-        **kwargs)
-
     # Run the ABI test.
     abi_test_env = {
         'PYTHONPATH' : WithProperties("%(workdir)s/" + f.llvm_srcdir + "/utils/lit:${PYTHONPATH}"),