[PATCH] D69149: [GISel][CombinerHelper] Add a combine turning shuffle_vector into concat_vectors

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 16:40:08 PDT 2019


qcolombet marked an inline comment as done.
qcolombet added inline comments.


================
Comment at: lib/CodeGen/GlobalISel/CombinerHelper.cpp:190
+  LLT DstType = MRI.getType(MI.getOperand(0).getReg());
+  unsigned Src1 = MI.getOperand(1).getReg();
+  LLT SrcType = MRI.getType(Src1);
----------------
arsenm wrote:
> s/unsigned/Register/
Good catch!
(Habits are hard to kill :))


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69149/new/

https://reviews.llvm.org/D69149





More information about the llvm-commits mailing list