[PATCH] D69107: [ThinLTO] Don't internalize during promotion

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 17 13:41:16 PDT 2019

Previous message: [PATCH] D69107: [ThinLTO] Don't internalize during promotion
Next message: [PATCH] D69107: [ThinLTO] Don't internalize during promotion
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

steven_wu added a comment.

I think this change is generally good but sorry I am not quite familiar with the semantics of comdat. Can you explain in more detail why that can be a problem to internalize that in promote?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69107/new/

https://reviews.llvm.org/D69107

Previous message: [PATCH] D69107: [ThinLTO] Don't internalize during promotion
Next message: [PATCH] D69107: [ThinLTO] Don't internalize during promotion
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list